Commits
- Commit:
a0abeae54173ae5718c4d39250ee22483512e59b
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got/tog/gotadmin: pledge earlier
In the case of tog move setlocale(3) before pledge(2), as suggested by
stsp.
ok stsp@
- Commit:
11a2b20c6274fd87160362f39493d1b0b013e443
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
send_tree_entries: simplify len computing
- Commit:
d392cc0a86905f1c82da0736472b8ad89248c476
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make 'got fetch -b branch' error reporting more helpful
The patch to got-fetch-pack.c was written by stsp with only minor tweaks
by me. Regress updated to account for the change in reporting.
stsp's original got-fetch-pack.c diff ok op jamsek
ok stsp@
- Commit:
31b44417d9846a733ca0b1f2746283fc261a68f0
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
regress: fetch -b/got.conf/wt/remote HEAD interaction
The added test checks we honour the correct precedence of branches to be
fetched, which is determined by: the -b flag; branches set in got.conf;
the work tree's current branch; and the remote repository's HEAD branch.
If a branch is specified with -b, only fetch this branch and if it does
not exist, simply report to the user--do not fallback to other branches.
Otherwise, if branches are either not set in got.conf or are set but do
not exist on the server:
- if invoked in a work tree, fallback to the work tree's current branch
- if not in a work tree or the work tree's current branch does not exist
on the server:
- fallback to remote HEAD.
With this, only the -b case can result in an unsuccessful fetch due to the
requested branch(es) not existing on the server. All other cases will either
fetch updates or report "Already up-to-date" (excepting errors).
ok stsp@
- Commit:
e0380e3dfa71712eaaf9642b4d86b53e6a986653
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
special case 'got fetch -b <branch>' to only fetch <branch>
As discussed on irc, this drops the implicit remote HEAD fetch when -b is used.
got.1 has been updated to make the new fetch behaviour clear.
ok stsp@
- Commit:
83592549c4d0fd93b998c76efe6d1cb9286d4e8b
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
style
- Commit:
a796e0cb12ad167297cddaf8af0067b49ba52b44
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
typo
- Commit:
dfd83cb68e2d3908e0e8774b3a13200a28c7afc0
- From:
- Mikhail <mp39590@gmail.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
style(9): function call in initialiser patch by Mikhail
- Commit:
25b84e6cea4c9658ea8ffc7af2928f0b254069ca
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
lib/object_create.c: calloc object ids
future fields added to the got_object_id will be implicitly zeroed
instead of gibberish.
ok stsp@
- Commit:
8f464e92b2e71ae647c139f4937a2390d159eec2
- From:
- Tracey Emery <tracey@traceyemery.net>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: abort tree and blob as well
- Commit:
ad5cb26d7ea1326e3b195caa3b459ea287aded90
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: abort blame if the client disconnect midway thru
Without setting err when the callback fails we continue the blame
machinery.
- Commit:
088f4d22ce3dcd3090bd440308e0b8b4fc8529aa
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make new log message modication check more robust; fixes regress fallout
ok jamsek
- Commit:
64a300dd8d0fd181638cad5dfdeba7582cb92093
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
garbage-collect redundant read_logmsg() parameter
As identified and suggested by stsp, with the previous commit,
'strip_comments' is now always set thus no longer needed.
ok stsp@
- Commit:
83389425cc9afb887c5428f2db3299a1b049d71e
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got: use timestamp and emptiness to validate log message
As suggested by naddy: consider commit log messages valid provided the temp
file time stamp has changed and the file is not empty. This heuristic
provides the desired behaviour (i.e., reusing cherrypicked/backed-out log
messages) that's currently provided but is simpler to grok.
Improved by and ok stsp@
- Commit:
1ff8274840d12a105064c246d5602b0e93957be5
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
convert two files to utf8
ok stsp
- Commit:
e2d314ead910671af065da16bf254aaffc2193a1
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
add a TODO item for gotadmin pack command
- Commit:
5b289346a9a33da176f47bfd6e879cb8ed6ab41b
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
open_blob: copy whole id not just the sha1
- Commit:
38bdc99fc83d59d7c507555551823c6e31c3cde0
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
remove recv_disconnect() from repo_write.c; missed in previous commit
- Commit:
92db09ff823dd814cbde563bb4455af59ba66415
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
do not expect to see a DISCONNECT message in repo processes
The parent no longer sends this message. Perform related cleanup
in the shutdown path instead.
ok op@
- Commit:
4301059192a1614d1ae81c9c61820487bd15f9bb
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
add functions to extract object ids from fileindex entries
ok stsp
- Commit:
52939b686ae906897e9b7956b61d15c255539e6d
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix gotd segfault in libevent while disconnecting clients
Sending a DISCONNECT message to the repo process and then killing
it and freeing its structure won't work. The message ends up on
internal libevent queues and will soon crash because we have freed
the memory for the event structre.
Sending that message is a leftover from the times when the repo
procs were persistent.
- Commit:
43c08a530e595df40d8133b9a3f77318c2a04b44
- From:
- Tracey Emery <tracey@traceyemery.net>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
rm unused boolean grammar. ok stsp@
- Commit:
75a8c854e063f97e5a2605f5256a1ce15ffb2f24
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make edits made to comments count as a log message modification
This supports use of cherrypick/backout without requiring the user
to modify the log message of the original commit.
ok jamsek, op
- Commit:
96d694ac3bc159099a9ad93aa49ec7ac1764b18d
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix gotd and gotsh usage() function declaration
"function declaration isn't a prototype"
should fix the error seen by tracey@ on sparc64
- Commit:
b7acbe65b9c3861892ccd85dce82d78aeb285f54
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make gotd parent dispatch handlers more robust during teardown
We have observed gotd exiting after "cannot find client for fd N" errors.
If this occurs then we are likely in the process of disconnecting a client
session while processing an event from a child process. Treat the above
error as non-fatal and stop processing more events from the child process.