Commits
- Commit:
756050ac401f1e724f0c1fd97af4a9855589c703
- From:
- Omar Polo <op@omarpolo.com>
- Date:
mark got_error_fmt as printf-like and fix the arisen errors
ok stsp@
- Commit:
61af9b215c06bece11deb27d941b390b81e0f8c6
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
implement support for commit coloring in got-read-pack for speed
ok op, tracey
- Commit:
58e31a80da4f4a9e10eaea148672190f35107a47
- From:
- Omar Polo <op@omarpolo.com>
- Date:
build with -Wwrite-strings
Throwing this into the mix for a while, we can always get rid of it
again if it becomes annoying. No objections from stsp@
- Commit:
3d589bee0bbbe812bb91f3b0284fbf2596304132
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
allow start_pack_privsep_child() to be called from outside lib/object.c
- Commit:
336075a42a5ae0fa322db734c481d21998e82bb8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
build with -Wmissing-prototypes
ok stsp@
- Commit:
db9b9b1c2b70d98419e70b05e7283b2284bedbec
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
let got-read-pack be explicit about whether it could enumerate all objects
This allows the main process to avoid looping over all object IDs again
in case the pack file used for enumeration is complete.
ok op@
- Commit:
eb7b30a1caf056832bec7619ececf88efa18f6bd
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix error handling in find_pack_for_enumeration(); pointed out by op@
- Commit:
0ab4c95723904e176687f5edc131bdf422dd261a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
Bring back object enumeration inside got-read-pack as a fast path.
The problem that was found in the earlier version has been fixed.
ok op@
- Commit:
e44d939152693c16e95d2855b539ad6b30e81b15
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
revert object enumeration in got-read-pack for now; needs more work
This implementation marked commits and trees as enumerated before all trees
which they depend on were enumerated. This behaviour leads to incomplete
pack files when a tree is only partially packed and got-read-pack hits
a missing tree entry as a result. The algorithm must be reworked such
that packed leave nodes are marked enumerated first, then bubble-up.
Found by op@
- Commit:
9f4f302a43f7e186910d59f9dbe0f839b6f2d565
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
free id and path in load_packed_tree_ids() on error, else they would leak
pointed out by op@
- Commit:
cee6a7ea556f9f3ae0f50df959c2acd8cb59bf80
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
implement object enumeration support in got-read-pack
ok op@
- Commit:
ce2bf7b7c9058374563c6db8608dbab9df2bba7d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix a bug in findwixt() which caused pack files with missing parent commits
The 'nskip' variable is supposed to reflect commits which are waiting on
the queue and have the 'skip' color. Only increment 'nskip' when adding
such commits to the queue.
Problem observed with got send -T and a tag pointing to a deleted branch.
Test to reproduce the bug written by op@.
- Commit:
d6a28ffe187127e3247254d7e242bb52d66eb26b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use random seeds for murmurhash2
change the three hardcoded seeds to fresh ones generated on demand via
arc4random. Suggested/fixed by and ok stsp@
- Commit:
17cfdba68dcb4432269af930abb1f9fb9ee48e97
- From:
- Omar Polo <op@omarpolo.com>
- Date:
include header
- Commit:
411cbec1f714f639184814306c5c88454521e289
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
shrink struct got_pack_meta a bit by removing the have_reused_delta flag
This flag can be expressed as m->reused_delta_offset != 0 because all
deltas in valid pack files will be written at a non-zero offset.
We allocate a huge number of these structs during packing, so every
little bit helps.
- Commit:
adb4bbb29d6a1407355e47e71716ca7f40c6dd67
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
reduce the amount of memory used for caching deltas during deltification
With files sorted properly for deltification we produce better deltas
but end up consuming more memory and risk running into OpenBSD ulimits
during packing. To compensate, reduce the threshold for the amount of
delta data we store in memory, spooling more deltas into the cache file.
ok op@
- Commit:
f8174ca59ba426ea9c475fd15d2db770f8595b5e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
store a path hash instead of a verbatim path in pack meta data
This reduces memory use by gotadmin pack. The goal is to sort files
which share a path next to each other for deltification. A hash of
the path is good enough for this purpose and consumes less memory
than a verbatim copy of the path. Git does something similar.
ok op@
- Commit:
3e6ceea0bd8a65737eb2231ce18d0e591dfb92ff
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix paths stored in pack meta data, improving file deltification
The old code was broken and stored an empty path or filenames, instead
of a repository-relative path. Which means we didn't sort files for
deltification as was intended.
Fixing this provides much better deltas in large pack files written by
gotadmin pack -a. In my test case, pack size changed from 2GB to 1.5GB.
ok op@
- Commit:
17259bfa94068499f61aec3129c47ae2671bd531
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
plug a small memleak on error in got_pack_create()
- Commit:
e93fb944fe7b32d96fafd4726043a28062563b54
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
map delta cache file into memory if possible while writing a pack file
with a fix from + ok op@
- Commit:
dc3fe1bf10950c200037f0198f2445ea176f8cc3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix load_object_ids() such that packing tags works if zero commits are packed
reported by jrick and op
- Commit:
fae7e03842e8618973f4d4910a86a52d881ab2ab
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
run the search for deltas to reuse in got-read-pack
This significantly speeds up the deltification step of packing by
avoiding imsg traffic. gotadmin no longer requests individual raw
deltas from got-read-pack to check whether it can reuse them.
Instead, got-read-pack obtains a list of objects we want to pack,
and hands back the list of all deltas in its pack file which can be
reused. Messages are now batched such that imsg buffers are filled
as much as possible.
Another advantage is that deltas we are not going to reuse will
no longer be written to the delta cache file, saving disk space.
Before this patch, any raw delta candidate was written to the
delta cache file by got-read-pack, and the decision whether to
reuse the delta happened afterwards in the gotadmin process.
Code for reading individual raw deltas is now unused and could be
removed at some point.
ok op@
- Commit:
2f8438b006e9015401b93f55cea57b36b021ce56
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid 'remove unused' loop by storing excluded objects in a separate set
ok op@
- Commit:
f5e78e05ae4eb8c5e5909841ee696fa5b6d0dfea
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid loop over the ID set which removes objects IDs with reused deltas
ok op@
- Commit:
2d9e6abf243a0a1895786fa9002b28d69a0f6fea
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
store deltas in compressed form while packing, both in memory and cache file
This reduces memory and disk space consumption during packing.
with tweaks + memleak on error fix from op@
ok op@