Commits
- Commit:
ea4ee74a619549cdfbbf7f824599834f31b72838
- From:
- James Cook <falsifian@falsifian.org>
- Via:
- Omar Polo <op@omarpolo.com>
- Date:
regress/cmdline: fix handling of unexpected success
Diff from James Cook, thanks!
- Commit:
2f3ccc5ff648594ff13619e304c2a139a917f2d2
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gather_on_disk_refs(): skip over bad refs
noticed since gotwebd fails when there's a ref.lock file due to a
concurrent update. discussed with stsp.
- Commit:
1df1761f7094815d15b11a908b2132ca58169fea
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotd show relevant commit hashes in error message if ref-updates collide
- Commit:
f8780fee7a5de8db320833efc4a30aa1ad3814e2
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotd avoid re-writing existing ref files when a ref-update is a no-op
- Commit:
4448825ab554378228429f5ac53c9cf943cc2503
- From:
- Omar Polo <op@omarpolo.com>
- Date:
dropping unnecessary strlen()s
ok jamsek, stsp
- Commit:
39c864a48b9d156c8b748725f5f89b3bd3f65038
- From:
- Omar Polo <op@omarpolo.com>
- Date:
avoid strlen in for(;;)
ok jamsek, stsp
- Commit:
f987c90b41240068719f2c9e5638fbd442adfdad
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
ignore write errors to pack children while closing a repository
If the child has exited for some reason then we won't be able to send a
stop message on the pipe. Ignore such errors while we are tearing a repository
data structure down. The error should be harmless but can trip up gotwebd
when cycling repositories out of its repo cache:
gotwebd[29683]: gotweb_render_index: got-portable.git: unexpected end of file
- Commit:
f4a5cef1546205afab47f148edefabcf77c06d3b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: set chroot path in config_init()
saves a bit fiddling around with ternary operators. sockets_run()
will reset the chroot to the default since it calls again config_init(),
but at that stage it's not important anymore.
ok stsp@
- Commit:
23c35dae297d2eecd13e17118a547761314a578d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
change got_get_repo_tags' limit argument to size_t
The function already carefully avoids wrapping around zero. While
here add a sanity check for limit == 0, like what was previously done
for got_get_repo_commits().
- Commit:
a678036d5fc91d90d799f3ed394f0f721d227d12
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd.conf: error if chroot is the empty string
- Commit:
1a0c81fb613b80af38dbc7f37c12f42a34b363d6
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd.conf: range-check numeric values and raise errors
- Commit:
031687baf3081932383b85041c49de781c43e432
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd.conf: disallow yes/no for booleans
Supporting both "no" and "on" as valid syntax with an opposite
meaning could easily result in accidental misconfiguration.
Suggested by stsp, tracey agrees. Patch by Josiah Frentsos, thanks!
- Commit:
d571a1762e9ff7281a5363373468c1e00a62ed42
- From:
- Omar Polo <op@omarpolo.com>
- Date:
drop unused strlen; ok stsp@
- Commit:
0a2fc48663670b6fb1a778aafc653227c9103442
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: make got_get_repo_commits take a size_t
and while here make sure 0 is rejected.
requested by, improvements and ok stsp@
- Commit:
f4425f95a55d6c26f06ecef7b3b8aa6a4a4247de
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: disallow 1 for max_commits_display and report range errors
ok stsp
- Commit:
5144d22b0c3bcf6611cc36e93a3a859fcc521277
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: simplify got_get_repo_commits(): don't traverse all the commits!
In some cases (e.g. limit=1 for DIFF action) we could end up traversing
all the commits instead of fetching just the one requested. Needless to
say, this makes the diff page extremely slow.
reported by and ok stsp@
- Commit:
563ffc1b6d823b71bab79a0a75c67524f3d0f447
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got, tog: correctly skip HEAD in build_refs_str()
s[strlen(s)] == '\0' is banally always true, the intent was to not skip
refs that starts with "HEAD".
style nit / ok stsp@
- Commit:
c6119c6d1145977d2ae8fb6754a9c369731d8dec
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make 'got status' error out as intended when invoked in a repository
- Commit:
ac8217d34e24bbe491283bcbb33dc63fac02cfa8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: drop a few unneeded SRCS
fileindex.c, worktree.c, worktree_open.c and patch.c are not used
in gotwebd.
ok stsp
- Commit:
8476cc2a23a92d71e099294a31fa7a70bff9c822
- From:
- Omar Polo <op@omarpolo.com>
- Date:
remove proc_ispeer()
unused, and was dropped by the other copies of proc.c; reduces the
diff with httpd' proc.c.
- Commit:
baaae61518bf323d22055a3b02fc9e129ee6d567
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotd avoid a "failed to push some refs" error from no-op 'git push'
gotsh was sending errors such as "unexpected end of file" and
"unexpected flush-pkt" to the client when the client disconnected
immediately after receiving reference announcements from the server.
As a result, 'git push' with both sides up-to-date would show an
obscure error message:
= [up to date] main -> main
error: failed to push some refs to 'ssh://example.com/git/repo.git
Now we see:
= [up to date] main -> main
Everything up-to-date
ok jamsek
- Commit:
cf31b4749a965b44fa03a3c98bdfc8b60f2c987d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix a segfault in got diff when a root commit is passed to -c
Problem reported by Alexander Arkhipov
ok jamsek
- Commit:
1f8d584437c06db990ac352cce06402c80b1f6a4
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
bump version number
- Commit:
9602b7807847f2cc7e385909e7d05dcf51e76abf
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
CHANGES for 0.89
- Commit:
6b5246e4d4f6c6cbd079a43d14042d998fbc902f
- From:
- James Cook <falsifian@falsifian.org>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
make 'got merge -c' fail even if new changes only affect unrelated paths
Otherwise, 'got merge -c' can silently revert already committed changes.
Also fix GOT_ERR_MERGE_COMMIT_OUT_OF_DATE by giving it a value distinct
from GOT_ERR_MERGE_STAGED_PATHS.
Patch by James Cook