Commits
- Commit:
388e7b970816daf27b983c96507e5a68ddf63ed7
- From:
- Omar Polo <op@omarpolo.com>
- Date:
some typos
courtesy of codespell; ok stsp@
- Commit:
a80b99e21fc857df67ec90b2b3d86ea3b87de4b1
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove a duplicate imsgbuf_clear() call
- Commit:
c82b772cec8b87e850bf1f7f6ce616ac189579af
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove another gotsysd todo item that is done
- Commit:
934d393715132f45c75259184bd798a8ebb0a082
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotsys-apply-conf use gotd reload instead of stop + restarting
- Commit:
476374d8eb748fb68a2604fd7155a4cbeb80ccd6
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
set close-on-exec flag on more files used during gotd reload
- Commit:
ef5e843f236f129cd9d8cd452e36ba5fbdb961a2
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
repair build of gotctl and gotsh following the gotd_imsg file split
- Commit:
70259cdf1bf2860ee303c2f581cfaa08dba2edef
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
move duplicated gotd_imsg functions into a single source file
- Commit:
9619bad01228458bc938f90c107e32158e635bae
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
provide imsg-based variants of gotsys check/apply for gotd to use
This allows for better inter-process communication, making error reporting
easier. It also avoids closing standard output and standard error channels
in a freshly forked child process, which seems to be a bad idea.
- Commit:
0fbf6ccc8a35712208f91ab1397cd0b5eb927e6a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
set close-on-exec flag on gotd socket to avoid it leaking during reloads
- Commit:
5f4e1ba7c031235f36541d39ad34d09bc24fc85c
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid double-close of gotd_reload_conf_fd
- Commit:
a64024d22dee547edfe438e51c7660d868cc0306
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
in gotsys-apply-conf, avoid using a -1 socket fd if gotd is not running
- Commit:
c58432778b0d60779066b29fdcfd2be65e485820
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
Xr gotctl and document SIGHUP issue
- Commit:
b8002eb1bd82761b269bfcea9e5a3d14e880a25e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
implement reload support in gotd, triggered via gotctl reload
Reload must be triggered via 'gotctl reload' rather than SIGHUP because
once gotd has dropped root privileges the gotd-secrets.conf file becomes
permanently inaccessible. When SIGHUP is received gotd now logs a message
which points the user at 'gotctl reload'.
- Commit:
db8be6f20a215d27d0037ce8bbc87c76409189bd
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
set close-on-exec flag on client connections in gotd parent process
Ensures that existing clients will be properly disconnected once the
gotd reload feature is introduced.
- Commit:
8d07ef48ecf42b004c38bb48b0eec3eb5cd06a30
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove closefrom() in gotd when gotsys is run
closefrom doesn't have the desired effect as it may affect unrelated open
files in the parent process. The right way to deal with this seems to be
setting the close-on-exec flag on file descriptors instead.
- Commit:
52b119c266230d82148c26d259a94c5c424c58b3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
drop pointless imsgbuf_allow_fdpass() calls from gotctl
- Commit:
afc8f605e6be7e47151b1854508bbae037286845
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
merge two subsequent if (proc_id == GOTD_PROC_GOTD) blocks.
- Commit:
bc746007fdbaeaef4fa096c7702ee3d92db1768c
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
only the gotd parent process is able to drop root privs, make this more obvious
- Commit:
2fae11eba5d55ee098e25416cd2917c9726e3457
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
we can now greatly simplify the conditional which guards reading of gotd.conf
- Commit:
30f4f45ab170674753968ff93bec290413aa0b04
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
send request timeout to session_read so it no longer needs to read gotd.conf
Also stop reading gotd.conf in repo_read, which is a trivial no-op.
- Commit:
c053f075633c96e223da5a7f351ae2ecbe75cce7
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make gotd session_write actually use the request timeout from gotd.conf
- Commit:
05d7513b8f5a498cf4650030f42f098517dd2789
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove duplicate break statement
- Commit:
2377fc912768339da9eab8092dc3e596b27d22c5
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
send notification targets to notify process
This removes the need for the notify process to read gotd.conf,
ensuring consistent run-time behaviour when gotd.conf is edited
while gotd is running.
- Commit:
9a1bdb2e47f2507c4d288aee8588e29b0e3aea2d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
send notification configuration to the gotd session_write process
This allows the session_write process to work without reading gotd.conf.
Again, we gain consistent run-time behaviour since changes to the
notification configuration in gotd.conf will not take effect until gotd
is restarted. However, the notify proccess still needs the same fix.
- Commit:
b8ff4847a4a4110f1e067cd8a90256e9f1d5d5af
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
cache our local repository name, not the name sent by the client